Repository navigation
rbac tests: a lane binding addresses one version (correct the R7 framing from #2024) - #2025
Merged
Merged
Conversation
The test called a source advance refusing an old binding a gap. It is the intended per-version behaviour: versions are not compacted, the old binding still names its version, and binding again against the new seal reads the new version. Renamed, comment rewritten, and the rebind is now asserted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XAqKMPJjVvasjwqhjJ6c9p
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2024 described one test as a gap and as an open decision ("a source revision move also refuses the address binding … stricter than EXO-255"). That statement was false.
A lane binding addresses one version of the frame. Versions are not compacted, so the bound version stays what the binding names. A source advance creates a new version:
LaneBinding::checkrefuses the old binding instead of silently following, and binding again against the new seal reads the new version. Nothing needs deciding.Change
crates/lance-graph-rbac/tests/scoped_lane_binding.rsonly:finding_a_source_revision_move_refuses_the_address_binding_tootoa_binding_addresses_one_version_and_a_source_advance_is_read_by_binding_again.checkreturnsOk. A first attempt rebound with the old seal and was refused, which is the expected behaviour; the bound version is named by its seal.The description of #2024 is corrected in place, with a note that it was edited.
Evidence
cargo test -p lance-graph-rbac --test scoped_lane_binding: 18 passed.-D warningsand fmt are clean.Generated by Claude Code